[CFAMX-20652] Refactor GetFinancialLinkedGroups to not use UNION - HotSchedules JIRA

Details

Type: Story
Status: Open (View Workflow)
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
- Performance-HighTraffic
- TechDebt

Work Type Classification:
Sustaining

Description

Rewrite the method to use something akin to the joins and where clause in:

select
				cd.TransactionCashDepositID,
                  sum(cdf.Amount * (((fg.OperationEnum*2)-1)*-1)) as Amount,
                  sum(cdf.Quantity) as Quantity
            from
                  tbtransactioncashdeposit cd with (nolock)
            join tbtransactioncashdepositfinancial cdf with (nolock)
            on cd.TransactionCashDepositID=cdf.TransactionCashDepositID
            join dbo.fn_GetFinancialTypeGroups(1) fg 
            on fg.FinancialGroupID=cdf.FinancialGroupID or fg.ChildFinancialGroupID=cdf.FinancialGroupID
            LEFT JOIN tbEntityZone ez with (nolock)
            on ez.ZoneID = fg.ZoneID AND ez.EntityID = cd.EntityID
            where
                  (fg.ZoneID IS NULL OR ez.EntityID = cd.EntityID)
                  AND fg.Status != 0
				  AND ISNULL(fg.OperationEnum, 0) != 2
				  AND cd.EntityID = @EntityID
				  AND cd.CashDepositDate >= @StartDate 
				  AND cd.CashDepositDate <= @EndDate 
            group by
                  cd.TransactionCashDepositID