Uploaded image for project: 'CFA MX '
  1. CFA MX
  2. CFAMX-25229

Signal - InFORM Receive API - path - /api/transfer/updatetransfer should not allow decline values more than original transfer

    Details

    • Type: Testing Defect
    • Status: Done (View Workflow)
    • Priority: Critical
    • Resolution: Completed
    • Affects Version/s: CFA 2023R3
    • Fix Version/s: CFA 2023R3
    • Component/s: None
    • Labels:
      None
    • SCRUM Team:
      Globogym Purple Cobras
    • Sprint:
      2023.R3 Signal Int. Sprint 3

      Description

      Scenario - could be that Signal will never partially decline more than what was transferred so this may not be an issue ever that we need to check for on our side, but just in case, I wanted to point it out. The Scenario is this - A transfer is created from a NON signal store in INFORM and then partially RECEIVED by Signal. If SIGNAL partially receives our API /api/transfer/updatetransfer allows for more than the originally transferred amount. 

      Steps to reproduce: 

      1- Create a Transfer in the UI on the InFORM side to a SIGNAL store (00663) for 5 - 36lb Cases of itemid = 14

      2-  Signal will send back a tbTransactionTransfer.SignalTransferID (JAT - 16381) for the transactionTransferid = 554784

      3 - Using the INFORM Receive API - /api/transfer/updatetransfer - pass in values for TransferQTY1, TransferQTY2 and TransferQTY3 for this item only partially receiving. In this case, I used this BODY
      {
        "signalTransferId": 16381,
        "details": [
          

      {       "code": "72",       "reasonCode": "Multi-unit order distribution",       "deniedTransferQty1": 1,       "deniedTransferQty2": 2,       "deniedTransferQty3": 3,            "declineComment": "This is a test from JMeter"     }

        ],
        "isApproved": true,
        "transferNote": "Some Note on Transfer",
        "temperatureChecked": true,
        "crossContaminationChecked": true
      }
       
      DEFECT: 
      The API should not allow for values greater than the original values. The original values are in the DB in JAT here : 
      select * from tbTransactionTransferDetail with (nolock)
      where transactiontransferid in (select transactiontransferid from tbTransactionTransfer with (nolock)
      where TransactionTransferID in(554784,554785))


       
      This is also impacting the Transfer QTY and TransferCost.
       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                charles.wheeler Charles Wheeler
                Reporter:
                charles.wheeler Charles Wheeler
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4h
                  4h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h
                  4h

                    PagerDuty

                    Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.