Details

    • Sprint:
      CFAMX 2020R1 Sprint 5, CFAMX 2020R1 Sprint 6
    • SCRUM Team:
      Brotherhood of Mutants
    • Story Points:
      3
    • Work Type Classification:
      Sustaining

      Description

      1. In CustomerSalesQueryService.GetTBCOutsideSalesTransactionSummary, this is Sorting by 3 separate fields at the service layer. This is probably not a huge deal except on really long lists but it's not clear why we would need to sort this data here instead of in the UI.
      2. In both CustomerSalesCommandService.UpdateTBCOutsideSale and CustomerSalesCommandService.DeleteTBCOutsideSale, these are still heavily Code \ NHibernate based. We have already converted the Service code to a SP to do similar work (dbo.MXC_AddOnAccountSaleToCustomer) so we should consolidate these and do everything more SP-based.
      3. There is a small client-side error when clicking on the edit button for a TBC that hasn't yet been assigned: TypeError: Cannot read property 'AccountName' of undefined. Not really an issue since the behavior is correct otherwise, but it would be nice to not have a bunch of erroneous errors on the page.
      4. In GetCustomerSalesTBDOutsideSales, it would be likely improve performance to change the first query in there to use transactiondate rather than businessday.
      5. In UpdateTBCOutsideSale, we are using the TransactionSummaryID and EntityID in the WHERE clause, which is pointless since we are already restricting on OnAccountSaleID.
      6. The sproc MXC_OldestTbcsWithNoCustomer could benefit from the same optimization mentioned above for GetCustomerSalesTBDOutsideSales.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                charles.wheeler Charles Wheeler
                Reporter:
                Corey.Amend Corey Amend (Inactive)
              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 44h Original Estimate - 44h
                  44h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 73.95h
                  73.95h

                    PagerDuty

                    Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.