-
Type: Story
-
Status: Closed (View Workflow)
-
Resolution: Completed
-
Affects Version/s: None
-
Fix Version/s: CFA 2020R1
-
Component/s: customerSales
-
Labels:None
-
Sprint:CFAMX 2020R1 Sprint 5, CFAMX 2020R1 Sprint 6
-
SCRUM Team:Brotherhood of Mutants
-
Story Points:3
-
Work Type Classification:Sustaining
- In CustomerSalesQueryService.GetTBCOutsideSalesTransactionSummary, this is Sorting by 3 separate fields at the service layer. This is probably not a huge deal except on really long lists but it's not clear why we would need to sort this data here instead of in the UI.
- In both CustomerSalesCommandService.UpdateTBCOutsideSale and CustomerSalesCommandService.DeleteTBCOutsideSale, these are still heavily Code \ NHibernate based. We have already converted the Service code to a SP to do similar work (dbo.MXC_AddOnAccountSaleToCustomer) so we should consolidate these and do everything more SP-based.
- There is a small client-side error when clicking on the edit button for a TBC that hasn't yet been assigned: TypeError: Cannot read property 'AccountName' of undefined. Not really an issue since the behavior is correct otherwise, but it would be nice to not have a bunch of erroneous errors on the page.
- In GetCustomerSalesTBDOutsideSales, it would be likely improve performance to change the first query in there to use transactiondate rather than businessday.
- In UpdateTBCOutsideSale, we are using the TransactionSummaryID and EntityID in the WHERE clause, which is pointless since we are already restricting on OnAccountSaleID.
- The sproc MXC_OldestTbcsWithNoCustomer could benefit from the same optimization mentioned above for GetCustomerSalesTBDOutsideSales.
- implements
-
CFAMX-7196 2020 R1 Refactor
- Closed
- relates to
-
CFAMX-7466 MXC - Customer Sales Refund - Refunded TBC w/Collected Sales applied no longer displays
- Done
-
CFAMX-7404 Embedded Customer Sales Help Article does not display in MMS
- Done
-
CFAMX-7405 Customer Sales- Details pane is not refreshed on Name Search
- Done
-
CFAMX-7447 Customer Sales - Inactive Account message is compressed
- Done
1.
|
Review Test Scripts | Done | Charles Wheeler |
|
|||||||||
2.
|
Deploy | Done | Soma Dixon (Inactive) |
|
|||||||||
3.
|
Functional Review with QA | Done | Sree Surapaneni |
|
|||||||||
4.
|
DIT | Done | Sree Surapaneni |
|
|||||||||
5.
|
Execute Regression Test Cases | Done | Charles Wheeler |
|
|||||||||
6.
|
Refactor Test Cases | Done | Charles Wheeler |
|
|||||||||
7.
|
Refactor TBC as suggested in notes | Done | Sree Surapaneni |
|